Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multiselect): set optional chaining for undefined multiselect #16066

Conversation

jesnajoseijk
Copy link
Contributor

@jesnajoseijk jesnajoseijk commented Mar 26, 2024

Closes #16052

Added optional chaining for undefined multi select value

Changelog

New

  • {{new thing}}

Changed

  • multiselect.tsx

Removed

  • {{removed thing}}

Testing / Reviewing

{{MultiSelect component}}

@jesnajoseijk jesnajoseijk requested a review from a team as a code owner March 26, 2024 07:44
Copy link
Contributor

github-actions bot commented Mar 26, 2024

DCO Assistant Lite bot: Thanks for your submission! We ask that you all sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text:


I have read the DCO document and I hereby sign the DCO.


1 out of 2 committers have signed the DCO.
✅ (jesnajoseijk)[https://github.com/jesnajoseijk]
@jesna-jose
JESNA-Jose seems not to be a GitHub user. You need a GitHub account to be able to sign the DCO. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

Copy link

netlify bot commented Mar 26, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4f5f95a
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66029a544ab9e50008294ff4
😎 Deploy Preview https://deploy-preview-16066--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jesnajoseijk
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@jesnajoseijk
Copy link
Contributor Author

recheck

@jesnajoseijk
Copy link
Contributor Author

closing since a new PR is raised

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Crash in MultiSelect with undefined selectedItems
1 participant