Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(structured-list): remove aria-busy from row #16067

Merged
merged 2 commits into from Mar 27, 2024

Conversation

janhassel
Copy link
Member

Currently, each StructuredListRow has aria-busy="true", announcing that the content within is being updated. Since that is not the case by default though, the attribute should not be present.

Changelog

Removed

  • Removed aria-busy="true" from StructuredListRow

Testing / Reviewing

  • Automated testing
  • Inspect DOM in storybook

Copy link

netlify bot commented Mar 26, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 85bb634
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6604314fe53b680007f83dcc
😎 Deploy Preview https://deploy-preview-16067--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@janhassel janhassel marked this pull request as ready for review March 26, 2024 12:18
@janhassel janhassel requested a review from a team as a code owner March 26, 2024 12:18
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm wondering why we had that on there 👀

@tay1orjones tay1orjones added this pull request to the merge queue Mar 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Mar 27, 2024
@alisonjoseph alisonjoseph added this pull request to the merge queue Mar 27, 2024
Merged via the queue into carbon-design-system:main with commit 77423b0 Mar 27, 2024
20 checks passed
@janhassel janhassel deleted the structuredlist-busy branch March 28, 2024 08:29
@carbon-automation
Copy link
Contributor

Hey there! v11.54.0 was just released that references this issue/PR.

preetibansalui pushed a commit to tay1orjones/carbon that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants