fix: collapse sidenav menus when side nav is closed #16096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
requested changes
Mar 29, 2024
There was a problem hiding this comment.
Generally display: none can't be used because it removes the element(s) from the accessibility tree and so it won't be read by screenreaders.
Instead of a style-related fix, would it make sense to modify the internal state of SideNavMenu to account for the change in the parent SideNav?
This bug was introduced #15349, my guess is the fix for this would be something similar to what was removed, but without reintroducing the bug it was fixing.
tay1orjones
requested changes
Apr 2, 2024
tay1orjones
approved these changes
Apr 2, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
carbon-design-system:main
with commit Apr 3, 2024
0619707
20 checks passed
preetibansalui
pushed a commit
to tay1orjones/carbon
that referenced
this pull request
Apr 24, 2024
…stem#16096) * fix: collapse sidenav menus when side nav is closed * fix: sidenav collapse issues * Update packages/react/src/components/UIShell/SideNavMenu.tsx * Update packages/react/src/components/UIShell/SideNavMenu.tsx --------- Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15900
Submenus should close when side nav closes
Changelog
Changed
Testing / Reviewing
Go to storybook , Open Side Nav -> Open Submenu -> Close side nav , sub menu should collapse autromatically.