fix: added href property to sideNavMenuItem #16113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
approved these changes
Apr 2, 2024
andreancardona
requested changes
Apr 2, 2024
andreancardona
approved these changes
Apr 4, 2024
andreancardona
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
Merged
via the queue into
carbon-design-system:main
with commit Apr 4, 2024
4633e13
20 checks passed
2 tasks
preetibansalui
pushed a commit
to tay1orjones/carbon
that referenced
this pull request
Apr 24, 2024
* fix: added href property to sideNavMenuItem * fix: updated snapshots * chore: update snapshots --------- Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com> Co-authored-by: Andrea N. Cardona <cardona.n.andrea@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15580
Added optional prop href to SideNavMenuItem
Changelog
New
Testing / Reviewing
Test SideNavMenuItem with href property in typescript environment. Verify that the TypeScript compiler should not throw error and the component renders without errors and correctly applies the provided href attribute.