Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs): missing key error in storybook #16119

Merged
merged 1 commit into from Apr 2, 2024

Conversation

alisonjoseph
Copy link
Member

@alisonjoseph alisonjoseph commented Apr 2, 2024

Closes #16051

Changelog

Add key to TabPanel in Tab stories

Testing / Reviewing

Make sure there are no more console warnings in tab stories
Warning: Each child in a list should have a unique "key" prop.

@alisonjoseph alisonjoseph requested a review from a team as a code owner April 2, 2024 18:47
Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 1cbceb4
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/660c52d6b3654900086ff527
😎 Deploy Preview https://deploy-preview-16119--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be placing keys on these by default if the user doesn't provide them?

@tay1orjones tay1orjones added this pull request to the merge queue Apr 2, 2024
Merged via the queue into carbon-design-system:main with commit a91b84d Apr 2, 2024
20 checks passed
preetibansalui pushed a commit to tay1orjones/carbon that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: [Tabs] Storybook warning: Each child in a list should have a unique "key" prop.
3 participants