refactor(overflowmenu): added typescript types for overflowmenu #16134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
andreancardona
approved these changes
Apr 10, 2024
|
@Gururajj77 looks like tests are failing |
The CI failed due to outdated snapshots, updated them. |
tay1orjones
reviewed
Apr 18, 2024
tay1orjones
reviewed
Apr 22, 2024
| @@ -297,13 +437,13 @@ class OverflowMenu extends Component { | |||
| evt.stopPropagation(); | |||
| if (!this._menuBody || !this._menuBody.contains(evt.target)) { | |||
| this.setState({ open: !this.state.open }); | |||
| onClick(evt); | |||
| onClick(); | |||
There was a problem hiding this comment.
Could consumers be relying on the evt to be passed as it was before?
There was a problem hiding this comment.
I am passing the evt now, and changed the type signature to accept a parameter optionally.
| @@ -347,11 +487,11 @@ class OverflowMenu extends Component { | |||
| this.state.open && | |||
| (!this._menuBody || !this._menuBody.contains(evt.target)) | |||
| ) { | |||
| this.closeMenu(); | |||
| this.closeMenu(); // Fix: Pass the onCloseMenu callback when calling closeMenu | |||
There was a problem hiding this comment.
Is this fixed? Or an outdated comment maybe?
There was a problem hiding this comment.
Its an outdated comment, I had added for my own reference, forgot to remove it.
tay1orjones
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: one more review 👀
labels
Merged
via the queue into
carbon-design-system:main
with commit May 2, 2024
f03c8d2
20 checks passed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13237
added typescript types to OverflowMenu component
Changelog
New
Changed
Testing / Reviewing
No new testing observations.