fix(modal): spacing below scrolling content #16223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisonjoseph
added
status: ready to merge 🎉
status: ready for review 👀
and removed
status: ready to merge 🎉
labels
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
approved these changes
Apr 18, 2024
tay1orjones
added
status: one more review 👀
and removed
status: ready for review 👀
labels
Merged
via the queue into
carbon-design-system:main
with commit Apr 26, 2024
9c1dc9c
20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15890
Changelog
Changed
Testing / Reviewing
Visually nothing should have changed with modal, you can add something like a button as the last element in storybook to test this update. Previously it would have applied padding inside the button vs. margin below.