Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(16207): adds NumberInput test coverage of allowEmpty #16254

Conversation

2nikhiltom
Copy link
Contributor

Closes #16207

Enhanced test coverage for the allowEmpty prop in the NumberInput component.

New

Included a new test case specifically addressing the behavior of the allowEmpty prop in the NumberInput component.
When the allowEmpty prop is set to true, the input field now accommodates empty values.

Testing / Reviewing

  • Open the repro in VSCode
  • run test suits for NumberInput
  • "yarn test packages/react/src/components/NumberInput"

Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1acf751
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/662f3acf72bd13000860cce7
😎 Deploy Preview https://deploy-preview-16254--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tay1orjones tay1orjones added this pull request to the merge queue Apr 29, 2024
Merged via the queue into carbon-design-system:main with commit b4e010d Apr 29, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve NumberInput test coverage of allowEmpty
3 participants