Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(overflowmenu/next): added typescript types to next/OverflowMenu component #16280

Merged

Conversation

Gururajj77
Copy link
Contributor

@Gururajj77 Gururajj77 commented Apr 29, 2024

Closes #15179

Added typescript types to next/overflowmenu component

Changelog

New

  • Added typescript interface for props

Changed

  • index.js to index.tsx

Testing / Reviewing

No new perspective needed

@Gururajj77 Gururajj77 requested a review from a team as a code owner April 29, 2024 12:04
Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ce35333
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/662fb3f95703660008db0c6c
😎 Deploy Preview https://deploy-preview-16280--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@tay1orjones tay1orjones added this pull request to the merge queue May 2, 2024
Merged via the queue into carbon-design-system:main with commit 6d0e7b6 May 2, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TypeScript types to next/OverflowMenu
3 participants