Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(overflow-menu): vertically align menu items #1662

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Jan 18, 2019

Closes #1661

This PR will vertically align the content within an overflow menu item regardless of whether or not the element is a <button>

@netlify
Copy link

netlify bot commented Jan 18, 2019

Deploy preview for the-carbon-components ready!

Built with commit ee505ec

https://deploy-preview-1662--the-carbon-components.netlify.com

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @emyarod!

Copy link
Contributor

@lovemecomputer lovemecomputer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@asudoh asudoh merged commit 7cc415a into carbon-design-system:master Jan 22, 2019
@carbon-bot
Copy link
Contributor

🎉 This PR is included in version 9.68.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@emyarod emyarod deleted the 1661-vertically-align-overflow-menu-item branch January 22, 2019 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants