chore(build): make dev Sass build faster #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used Sass importer because our dev env had `carbon-addons-cloud` code with circular dependency back to this repository (`carbon-components`). However, we found that it caused significant slowdown of our Sass dev build to an unacceptable level for change-style-and-see workflow. This change puts a copy of such `carbon-addons-cloud` code in this repository (as a dev-env-specific code) so we no longer need Sass importer, which yields 5x `sass:dev` task performance. In future, we should migrate from that code to UI shell side nav. Refs carbon-design-system#1502 and carbon-design-system#1709.
|
Deploy preview for the-carbon-components ready! Built with commit caf34ed https://deploy-preview-1718--the-carbon-components.netlify.com |
emyarod
approved these changes
Feb 1, 2019
joshblack
approved these changes
Feb 1, 2019
|
🎉 This PR is included in version 9.69.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
May 2, 2019
…n-system#1718) * feat(DropdownV2): add support for dropdown title and helper text * test(DropdownV2): add tests for title and helper text * chore(DropdownV2): update snapshots * fix(DropdownV2): replace `<FormItem />` wrapper with React fragment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used Sass importer because our dev env had
carbon-addons-cloudcode with circular dependency back to this repository (carbon-components). However, we found that it caused significant slowdown of our Sass dev build to an unacceptable level for change-style-and-see workflow.This change puts a copy of such
carbon-addons-cloudcode in this repository (as a dev-env-specific code) so we no longer need Sass importer, which yields 5xsass:devtask performance.In future, we should migrate from that code to UI shell side nav.
Refs #1502 and #1709.
Changelog
New
carbon-addons-cloudas a dev-env-specific code.Removed
sass:devgulp task.Testing / Reviewing
Testing should make sure our dev env is not broken.