Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(overflow-menu): match experimental spec #1808

Merged
merged 6 commits into from
Feb 15, 2019
Merged

fix(overflow-menu): match experimental spec #1808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5426dbe
fix(overflow-menu): show ellipsis for all overflowing child elements
emyarod Feb 13, 2019
556ee0d
docs(overflow-menu): add example with non-button child elements
emyarod Feb 13, 2019
7dfbc2a
fix(overflow-menu): darken menu option text on hover
emyarod Feb 13, 2019
a103d1e
Merge branch 'master' into 1807-component-design-audit-v1.1-overflow-…
jnm2377 Feb 14, 2019
6666d1a
Merge branch 'master' into 1807-component-design-audit-v1.1-overflow-…
aledavila Feb 14, 2019
a91669c
Merge branch 'master' into 1807-component-design-audit-v1.1-overflow-…
tw15egan Feb 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/components/overflow-menu/_overflow-menu.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@
align-items: flex-start;
position: absolute;
z-index: z('floating');
background-color: $inverse-01;
background-color: $ui-01;
width: 11.25rem;
list-style: none;
top: 32px;
Expand Down Expand Up @@ -305,6 +305,13 @@
border-top: 1px solid $ui-03;
}

a.#{$prefix}--overflow-menu-options__btn::before {
content: '';
height: 100%;
vertical-align: middle;
display: inline-block;
}

.#{$prefix}--overflow-menu-options__btn {
@include reset;
@include typescale('zeta');
Expand All @@ -314,19 +321,22 @@
width: 100%;
height: 100%;
border: none;
display: inline-flex;
align-items: center;
display: inline-block;
background-color: transparent;
text-align: left;
padding: 0 $spacing-md;
cursor: pointer;
color: $text-01;
color: $text-02;
max-width: 11.25rem;
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
transition: outline $transition--base, background-color $transition--base, color $transition--base;

&:hover {
color: $text-01;
}

&:focus {
@include focus-outline('outline');
}
Expand Down
25 changes: 25 additions & 0 deletions src/components/overflow-menu/overflow-menu.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,3 +58,28 @@
{{/each}}
</ul>
</div>

<div data-overflow-menu tabindex="0" aria-label="Overflow" class="{{@root.prefix}}--overflow-menu" role="button" aria-haspopup="true"
aria-expanded="false">
{{#if @root.featureFlags.componentsX}}
{{ carbon-icon 'OverflowMenuVertical16' class=(add @root.prefix '--overflow-menu__icon') }}
{{else}}
<svg aria-hidden="true" class="{{@root.prefix}}--overflow-menu__icon" width="3" height="15" viewBox="0 0 3 15">
<g fill-rule="evenodd">
<circle cx="1.5" cy="1.5" r="1.5" />
<circle cx="1.5" cy="7.5" r="1.5" />
<circle cx="1.5" cy="13.5" r="1.5" />
</g>
</svg>
{{/if}}
<ul class="{{@root.prefix}}--overflow-menu-options {{@root.prefix}}--overflow-menu--flip" tabindex="-1" data-floating-menu-direction="{{direction}}"
role="menu" aria-label="Overflow">
{{#each items}}
<li class="{{@root.prefix}}--overflow-menu-options__option{{#if disabled}} {{@root.prefix}}--overflow-menu-options__option--disabled{{/if}}{{#if danger}} {{@root.prefix}}--overflow-menu-options__option--danger{{/if}}"
role="presentation">
<a href="https://www.ibm.com" class="{{@root.prefix}}--overflow-menu-options__btn" role="menuitem" {{#if title}} title="{{title}}" {{/if}}
{{#if primaryFocus}} data-floating-menu-primary-focus{{/if}}{{#if disabled}} tabindex="-1" {{/if}}>{{label}}</a>
</li>
{{/each}}
</ul>
</div>