refactor(project): add react package #2417

joshblack · 2019-05-07T22:23:48Z

Adds carbon-components-react to carbon monorepo.

Reviewer checklist:

Lint staged works as expected
Editor plugins work as expected in nested package (like prettier)
Can still develop locally with storybook
GitHub files are up-to-date
CircleCI is running CI checks
ESLint works as expected
Tests run as expected, don't fail
Builds work as expected

This fix workarounds storybookjs/storybook#5080.

…m#1772) * fix(list-box): Prevent focus on open/close icon * fix(date-picker): Prevent focus on date-picker/input icon * fix(date-picker): Prevent focus on date-picker/input icon - snap

Fixes carbon-design-system#1183.

…em#1767) * docs(OverflowMenu): support `flipped` storybook knob * chore: bump carbon-components version * fix(OverflowMenu): pass trigger node and flip prop through FloatingMenu * docs(FloatingMenu): fix typo * fix(OverflowMenu): handle click on trigger button div

…tem#1795)

…n-system#1716) * docs(ContentSwitcher): use experimental icons * fix(ContentSwitcher): match vanilla markup * feat(ContentSwitcher): support `disabled` attribute * chore: bump carbon-components version

…n-design-system#1747) * fix(TimePicker): update markup to match experimental component * docs(TimePicker): fix typo

…m#1803)

* fix(TileGroup): use fieldset element for TileGroup wrapper * fix(Tile): place label after input control * test(Tile): account for new React.Fragment wrapper

…n-design-system#1808) * chore: update offline package mirrors * docs(TextInput): expose `defaultValue` prop as Storybook knob

…#1654) * docs(FormItem): add `hideLabel` prop to storybook example * feat(NumberInput): align NumberInput markup with vanilla repo * test(NumberInput): remove form item wrapper check * Revert "feat(NumberInput): align NumberInput markup with vanilla repo" This reverts commit 6abb5fcf2a5b2d9a329ce9739fee22628df4e132. * refactor(NumberInput): set default label value to empty string * Revert "test(NumberInput): remove form item wrapper check" This reverts commit c780e6a85231b948db541a119ba2c2a4602f9db9. * refactor(NumberInput): set default labelText based on feature flag * fix(NumberInput): match vanilla markup * fix(NumberInput): match vanilla markup and use caret glyph icons * refactor(NumberInput): use React fragment syntax

) * fix(ui-shell): remove aria menu keyhandlers * fix(ui-shell): remove unused variables * fix(ui-shell): return focus to menu button on escape * fix(ui-shell): remove unused variables * fix(ui-shell): run prettier and update snap shots

…n-system#1816) * fix(ui-shell): remove aria menu keyhandlers * fix(ui-shell): remove unused variables * fix(ui-shell): return focus to menu button on escape * fix(ui-shell): remove unused variables * fix(ui-shell): run prettier and update snap shots * fix(ui-shell): handle keydown enter on menuitems * chore(ui-shell): update snapshots * fix(ui-shell): refactor some event handler logic with Josh * chore(ui-shell): update snapshots

…esign-system#1812)

…sign-system#1809) * docs(Storybook): more detailed doc for using our Storybook * Update docs/components.md Co-Authored-By: asudoh <asudoh@gmail.com> * Update README.md Co-Authored-By: asudoh <asudoh@gmail.com> * docs(Storybook): minor updates

…em#1784) * fix(tab-content): add prefix to content classname * fix(tabs): remove unnecessary classname

…bon-design-system#1818)

…sign-system#1802) * feat(ListBoxMenuIcon): support translatable SVG icon title * feat(MultiSelect): pass custom SVG titles to ListBoxMenuIcon * chore: update snapshot * refactor(MultiSelect): use callback pattern for assigning SVG title * chore: update snapshot * fix(MultiSelect): remove default `translateWithid` prop value * chore: update snapshot

…#1800) * chore: bump carbon-components version * feat(PaginationV2): add experimental Pagination * chore: bump carbon-components version * fix(Pagination): render page range only when page input is enabled * refactor(Pagination): remove `isLastPage` prop

…arbon-design-system#1823) * chore: Update wai-aria on tooltip. resolve carbon-design-system#1494 * chore: Updates test. * chore: reverts triggers to div with button roles.

* refactor(AccordionSkeleton): Converted skeleton from class to functional component * feat(AccordionSkeleton): Added option to show first item opened or not * fix(AccordionSkeleton): Number of items differ for first item opened and closed variations * feat(AccordionSkeleton): Option to set number of items added

…-system#1830) * chore: bump webpack-dev-server in example package.json * fix: use caret prefix

* Update 'InnerClickListener' - check if event target exists in DOM - if it does not exist, should not trigger onClickOutside * Run prettier * Implemented suggestions fix * Fix failing tests * reordering boolean test elements * Trying different approach for IE fix * Attempt to fix failing test * Attempt fix 2 - check if target === body * Testing simpler version * Test simpler 2 * fix(InnerClickListener): added test case and reverted to previous fix * fix(InnerClickListener): Removing outdated comment

…system#1835) * feat(AccordionItem): add experimental Accordion Item * test(AccordionItem): Fixes tests for new icon components * chore(AccordionItem): Use aria label prop * fix(AccordionItem): Remove role null * chore(AccordionItem): Remove icon prop * chore(AccorionItem): Adds role null back into legacy icon

(carbon-design-system#1797) * docs(examples): usage of react-router, resolves carbon-design-system#795 * docs(examples): address prettier errors * docs(examples): remove svg * docs(examples): address review comments and use prebuilt css * docs(examples): accidentally updated incorrect file

…m#1787) * fix(components): avoid being shown as ForwardRef Fixes carbon-design-system#1786. * chore: use ForwardRef(ComponentName) * chore(components): avoid Object.assign() for ref forwarding components * Update src/components/Checkbox/Checkbox.js Co-Authored-By: asudoh <asudoh@gmail.com> * chore: bring missing React.forwardRef() call back * chore: bring missing React.forwardRef() call back

…design-system#1726) * feat(ProgressIndicator): update SVG icons and match experimental markup * feat(ProgressIndicator): support experimental overflow tooltip * fix(ProgressIndicator): avoid passing style prop to nested tooltips * fix(ProgressIndicator): allow assignment of tooltip ID for each step * refactor(ProgressIndicator): use render prop for overflow tooltip * refactor(ProgressIndicator): set default progress step label * refactor(ProgressIndicator): remove else-returns

This change removes RTL plugin of Storybook. Though it's a nice add-on, we require an additional build step to generate RTL version of CSS and that Storybook add-on does not seem to kick off an altern ate build. Refs carbon-design-system#2053. Refs carbon-design-system#2314. Refs carbon-design-system#2286.

* docs(TextInput): describe PropTypes * chore: update carbon peer dependencies * docs(TextInput): modify `type` storybook knob * feat(TextInput): add password visibility toggle * docs(TextInput): add `text` option to storybook types knob * test(TextInput): test password visibility toggle TextInput * refactor(TextInput): create PasswordInput component * feat(PasswordInput): allow custom `alt` text attribute * refactor(PasswordInput): pull out shared function * feat(PasswordInput): display tooltip text on hover of visibility toggle * feat: add ControlledPasswordInput component * feat(ControlledPasswordInput): set default `type` prop value * test(TextInput): add tests for PasswordInput and ControlledPasswordInput * feat(PasswordInput): allow custom password visibility toggle alt text * fix(PasswordInput): export named password input components * docs(TextInput): refactor story for storybook v4 * fix(PasswordInput): match experimental spec * fix(PasswordInput): rename attribute * test(TextInput): checkout test from master * test(TextInput): fix console warning * feat(ControlledPasswordInput): match v10 spec * test(PasswordInput): rename suite * test(ControlledPasswordInput): add test suite * fix(TextInput): add data-invalid attribute for v10 * refactor: remove v9 code * chore: sync forwardRef changes * chore: update lockfile * docs: revert comment changes * docs: space between propTypes

…f535aa' git-subtree-dir: packages/react git-subtree-mainline: b671ee6 git-subtree-split: f1d7ada

netlify · 2019-05-07T22:27:55Z

Deploy preview for the-carbon-components failed.

Built with commit 3f6b444

https://app.netlify.com/sites/the-carbon-components/deploys/5cd2e9630cd9cd00083eae14

…carbon-components into refactor/add-react-to-project

asudoh · 2019-05-08T10:04:08Z

FYI: I had an issue with my Storybook experimentation (after rebased to the version with monorepo) and below solved my issue:

"workspaces": {
  ...
  "nohoist": [
    "**/@storybook/**"
  ]
},

joshblack · 2019-05-08T14:31:40Z

@asudoh was this even with the latest update? I also had an issue with that but I thought the updated version fixed it

emyarod

dev env and tests work as expected for me

tw15egan

Everything works great for me, and styles update in React package when updated in Components 🎉

This reverts commit a94c305.

asudoh and others added 30 commits January 24, 2019 07:53

fix(Storybook): IE11 fix (carbon-design-system#1779)

6816636

This fix workarounds storybookjs/storybook#5080.

fix(list-box): Prevent focus on open/close icon (carbon-design-syste…

ed05ce9

…m#1772) * fix(list-box): Prevent focus on open/close icon * fix(date-picker): Prevent focus on date-picker/input icon * fix(date-picker): Prevent focus on date-picker/input icon - snap

fix(a11y): avoid empty label in ToggleSmall (carbon-design-system#1771)

45972b4

Fixes carbon-design-system#1183.

fix(MultiSelect): avoid repeated assignment of ids (carbon-design-sys…

a594080

…tem#1795)

feat(ContentSwitcher): add experimental ContentSwitcher (carbon-desig…

3acc87c

…n-system#1716) * docs(ContentSwitcher): use experimental icons * fix(ContentSwitcher): match vanilla markup * feat(ContentSwitcher): support `disabled` attribute * chore: bump carbon-components version

docs(OrderedList): create component story (carbon-design-system#1723)

6c9b883

fix(TimePicker): update markup to match experimental component (carbo…

910bcdd

…n-design-system#1747) * fix(TimePicker): update markup to match experimental component * docs(TimePicker): fix typo

chore(lint): ensure lint-staged formats the code (carbon-design-syste…

a527788

…m#1803)

fix(Tile): reorder component markup for a11y (carbon-design-system#1774)

c48f34c

* fix(TileGroup): use fieldset element for TileGroup wrapper * fix(Tile): place label after input control * test(Tile): account for new React.Fragment wrapper

docs(TextInput): expose defaultValue prop as Storybook knob (carbo…

959c1d1

…n-design-system#1808) * chore: update offline package mirrors * docs(TextInput): expose `defaultValue` prop as Storybook knob

docs(components): usage of feature flags (carbon-design-system#1794)

52cb36f

docs(OverflowMenu): highlight floatingMenu and primaryFocus (carbon-d…

6f73caa

…esign-system#1812)

fix(tab-content): add prefix to content classname (carbon-design-syst…

65ea387

…em#1784) * fix(tab-content): add prefix to content classname * fix(tabs): remove unnecessary classname

fix(radiobuttongroup): custom class should merge with base class (car…

a29fb4f

…bon-design-system#1818)

refactor(Notification): remove unused props (carbon-design-system#1832)

c2c6b70

chore: Update wai-aria on tooltip. resolve carbon-design-system#1494 (c…

d97f314

…arbon-design-system#1823) * chore: Update wai-aria on tooltip. resolve carbon-design-system#1494 * chore: Updates test. * chore: reverts triggers to div with button roles.

chore: bump webpack-dev-server in example package.json (carbon-design…

e069a9c

…-system#1830) * chore: bump webpack-dev-server in example package.json * fix: use caret prefix

asudoh and others added 8 commits May 7, 2019 08:11

Add 'packages/react/' from commit 'f1d7ada7bedd066c1fde3a6f5fde7e2c3d…

eff767d

…f535aa' git-subtree-dir: packages/react git-subtree-mainline: b671ee6 git-subtree-split: f1d7ada

chore(react): sync offline mirror

6f89a46

chore(components): sync docs to local folder

08e1b31

docs(github): update to include question for package

7189f98

chore(ci): update CI config and steps for lint-staged

9615f37

chore(project): sync yarn.lock

c9388df

joshblack changed the title ~~Refactor/add react to project~~ refactor(project): add react package May 7, 2019

chore(project): sync offline mirror

d7e62c3

joshblack requested a review from a team May 7, 2019 22:29

joshblack added 5 commits May 7, 2019 17:59

Merge branch 'master' into refactor/add-react-to-project

b3b2aac

chore(react): update storybook dependency

2a79915

chore(react): update dev env to use source path

65d4c8f

chore(project): update commitlint settings

7ccbbc5

Merge branch 'refactor/add-react-to-project' of github.com:joshblack/…

f7a6a8b

…carbon-components into refactor/add-react-to-project

Merge branch 'master' into refactor/add-react-to-project

3f6b444

emyarod reviewed May 8, 2019

View reviewed changes

joshblack mentioned this pull request May 8, 2019

refactor(project): add elements packages #2418

Merged

6 tasks

tw15egan approved these changes May 8, 2019

View reviewed changes

joshblack merged commit a94c305 into carbon-design-system:master May 8, 2019

joshblack deleted the refactor/add-react-to-project branch May 8, 2019 18:22

joshblack added a commit that referenced this pull request May 8, 2019

Revert "refactor(project): add react package (#2417)"

58c201f

This reverts commit a94c305.

joshblack mentioned this pull request May 8, 2019

Revert "refactor(project): add react package" #2419

Merged

joshblack restored the refactor/add-react-to-project branch May 8, 2019 18:23

joshblack added a commit that referenced this pull request May 8, 2019

Revert "refactor(project): add react package (#2417)" (#2419)

2cd27b1

This reverts commit a94c305.

joshblack mentioned this pull request May 8, 2019

refactor(project): add react package #2421

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(project): add react package #2417

refactor(project): add react package #2417

joshblack commented May 7, 2019

netlify bot commented May 7, 2019 •

edited

asudoh commented May 8, 2019

joshblack commented May 8, 2019

emyarod left a comment

tw15egan left a comment

refactor(project): add react package #2417

refactor(project): add react package #2417

Conversation

joshblack commented May 7, 2019

netlify bot commented May 7, 2019 • edited

asudoh commented May 8, 2019

joshblack commented May 8, 2019

emyarod left a comment

Choose a reason for hiding this comment

tw15egan left a comment

Choose a reason for hiding this comment

netlify bot commented May 7, 2019 •

edited