fix(data-table): reset expand button height in short table #3057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for the-carbon-components ready! Built with commit 107a14d https://deploy-preview-3057--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 107a14d |
|
Deploy preview for carbon-components-react ready! Built with commit 107a14d https://deploy-preview-3057--carbon-components-react.netlify.com |
emyarod
changed the title
joshblack
approved these changes
Jun 17, 2019
emyarod
added a commit
to emyarod/carbon
that referenced
this pull request
Jun 18, 2019
cal-smith
pushed a commit
to cal-smith/carbon-components
that referenced
this pull request
Jun 21, 2019
cal-smith
pushed a commit
to cal-smith/carbon-components
that referenced
this pull request
Jun 21, 2019
cal-smith
pushed a commit
to cal-smith/carbon-components
that referenced
this pull request
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3053
The expand button height for expandable data tables was identical for all data table variants, this PR unsets the height for short data tables
Testing / Reviewing
Ensure data table variants appear correct