fix(css): clean up css errors #3695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
alisonjoseph and
dakahn
and removed request for
a team
|
Deploy preview for the-carbon-components ready! Built with commit 2ad3dc0 https://deploy-preview-3695--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 2ad3dc0 |
|
Deploy preview for carbon-components-react ready! Built with commit 2ad3dc0 https://deploy-preview-3695--carbon-components-react.netlify.com |
|
Deploy preview for the-carbon-components ready! Built with commit 1c789d5 https://deploy-preview-3695--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 1c789d5 |
|
Deploy preview for carbon-components-react ready! Built with commit 1c789d5 https://deploy-preview-3695--carbon-components-react.netlify.com |
joshblack
approved these changes
Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3688
Cleans up some CSS errors we've had in our code base
Changelog
Changed
Tagskeleton now works properlyRemoved
Testing / Reviewing
Check
/demo/demo.cssat https://jigsaw.w3.org/css-validator/#validate_by_input and ensure there are no errors (Helps to comment outL86 - L124in/demo/scss/demo.scssto reduce custom property errors