fix(icons): update ci-check to fail with exit code 1 #3856
Conversation
ghost
requested review from
asudoh and
tw15egan
and removed request for
a team
|
Deploy preview for the-carbon-components ready! Built with commit 16818aa https://deploy-preview-3856--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 16818aa |
|
Deploy preview for carbon-components-react ready! Built with commit 16818aa https://deploy-preview-3856--carbon-components-react.netlify.com |
|
Deploy preview for the-carbon-components ready! Built with commit facfbe0 https://deploy-preview-3856--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit facfbe0 https://deploy-preview-3856--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit facfbe0 |
|
@joshblack is 2d7d006 to test that the fail working properly? |
|
@vpicone I think we renamed it to 3D-iCa right? It seems like our ci-check didn't pick up that we wanted to remove the asset, if we still want it totally fair! I can add back in the metadata |
|
@joshblack ah nvm Coulda sworn I renamed it properly in my PR... |
|
Note to reviewers, couple of TODOs left on my end:
|
…n into fix/update-icon-ci-check
|
Issue to update mis-categorized or misnamed icons: #3877 |
When handling our refactor, we had assumed
console.errorwould setprocess.exitCodeto1, instead theci-checkfails silently (withexitCodeas0). This updates it so that the catch handler exits with an exit code of1, signaling that an error has occurred and failing CI.Changelog
New
Changed
process.exit(1)to fail with code1Removed