fix(tile): update props to remove errors, update tile maxheight #4630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
jendowns
commented
Nov 8, 2019
|
Deploy preview for the-carbon-components ready! Built with commit 3c0361b https://deploy-preview-4630--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 3c0361b |
|
Deploy preview for carbon-components-react ready! Built with commit 3c0361b https://deploy-preview-4630--carbon-components-react.netlify.com |
joshblack
suggested changes
Nov 11, 2019
Co-Authored-By: Josh Black <josh@josh.black>
|
Thanks @joshblack! Just applied your suggestion 👍 |
joshblack
approved these changes
Nov 15, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4609
Changelog
Changed
expandedandonBeforeClickexplicitly so they aren't included in misc props that get passed to the component & cause 2 errors identified in React warnings in console with ExpandableTile #4609tileMaxHeightandtilePaddingto prevent theNaNerror identified in React warnings in console with ExpandableTile #4609 (comment)Also, optional but recommended:
expandedstate shares a name withexpandedprop. So to prevent confusion/collision, I suggestremovingusingconst { expanded } = this.stateand just referencingthis.state.expandedinstead.const { expanded: isExpanded} = this.state`