fix(header): reset default ul styling directly in header navigation menus #4674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
jendowns
changed the title
|
Deploy preview for carbon-elements ready! Built with commit f9d3d2a |
jendowns
changed the title
|
Deploy preview for the-carbon-components ready! Built with commit f9d3d2a https://deploy-preview-4674--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit f9d3d2a https://deploy-preview-4674--carbon-components-react.netlify.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4673
This PR applies 3 missing style rules to the
HeaderNavigationcomponent'sul.bx--header__menu-bar&ul.bx--header__menuelements.Currently the component relies on global reset rules to render correctly, but for consumers who don't use those global resets (like us), the
ul.bx--header__menu-bar&ul.bx--header__menuelements still have padding, margins, and default list-style rules applied.Changelog
New
ul.bx--header__menu-bar&ul.bx--header__menu