fix(copy-button): fix type of feedback text #4677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for the-carbon-components ready! Built with commit 7fbd19b https://deploy-preview-4677--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 7fbd19b |
|
Deploy preview for carbon-components-react ready! Built with commit 7fbd19b https://deploy-preview-4677--carbon-components-react.netlify.com |
emyarod
reviewed
Nov 14, 2019
|
I'm seeing the same thing as @emyarod |
laurenmrice
requested changes
Nov 14, 2019
joshblack
approved these changes
Nov 15, 2019
joshblack
reviewed
Nov 15, 2019
joshblack
suggested changes
Nov 18, 2019
| @@ -302,9 +302,23 @@ | |||
| } | |||
|
|
|||
| .#{$prefix}--snippet-button .#{$prefix}--btn--copy__feedback { | |||
| top: rem(25px); | |||
| top: rem(50.8px); | |||
There was a problem hiding this comment.
Where is this number coming from?
| .#{$prefix}--snippet--multi | ||
| .#{$prefix}--snippet-button | ||
| .#{$prefix}--btn--copy__feedback { | ||
| top: rem(42.8px); |
There was a problem hiding this comment.
Where is this number coming from?
ghost
requested a review
from 
|
Fixed the tooltip offset, and added the comment how the right offset is generated. Made a change to force serif font as our type token of choice doesn't dictate the font face and code snippet UI has monospace font. |
emyarod
reviewed
Nov 19, 2019
packages/components/src/components/code-snippet/_code-snippet.scss
Outdated
Show resolved
Hide resolved
laurenmrice
approved these changes
Nov 19, 2019
…scss Co-Authored-By: emyarod <emyarod@users.noreply.github.com>
joshblack
approved these changes
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4606.
Changelog
Changed
Testing / Reviewing
Testing should make sure copy button and code snippet is not broken.