Fix(HeaderMenu + HeaderNavigation): handle null item #4682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 63d96c6 |
|
Deploy preview for the-carbon-components ready! Built with commit 63d96c6 https://deploy-preview-4682--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit 63d96c6 https://deploy-preview-4682--carbon-components-react.netlify.com |
asudoh
approved these changes
Nov 14, 2019
joshblack
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4261
Allows
<HeaderMenu>and<HeaderNavigation>to handle a null item/child on render.Changelog
Changed
Testing / Reviewing
In
packages/react/src/components/UIShell/UIShell-story.jspass a null<HeaderMenuItem>to a<HeaderNavigation>and<HeaderMenu>component.ie change:
line 158 to
{false && <HeaderMenuItem href="#">Link 1</HeaderMenuItem>}line 162 to
{false &&<HeaderMenuItem href="#">Sub-link 1</HeaderMenuItem>}Link 1 should no longer be visible in the header, and sub-link 1 should disappear from the link 4 dropdown.