Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tabs): rename fixed variant to container #4685

Merged
merged 2 commits into from
Nov 15, 2019

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Nov 14, 2019

Fixes #4683.

Changelog

Changed

  • Renamed "fixed" variant to "container"

Testing / Reviewing

Testing should make sure tabs component is not broken.

@netlify
Copy link

netlify bot commented Nov 14, 2019

Deploy preview for the-carbon-components ready!

Built with commit db82ef4

https://deploy-preview-4685--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Nov 14, 2019

Deploy preview for carbon-elements ready!

Built with commit db82ef4

https://deploy-preview-4685--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Nov 14, 2019

Deploy preview for carbon-components-react ready!

Built with commit db82ef4

https://deploy-preview-4685--carbon-components-react.netlify.com

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you!

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@abbeyhrt abbeyhrt merged commit a4785f3 into carbon-design-system:master Nov 15, 2019
@asudoh asudoh deleted the tabs-container branch November 16, 2019 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tab] Change name from "fixed" to "container"
5 participants