feat(icons): Watson discovery icons #4696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds: improve-relevance.svg phrase-sentiment.svg folders.svg exit.svg document-sentiment.svg character-patterns.svg updates categories.yml and metadata.yml
ghost
requested review from
|
cc @conradennis |
|
Deploy preview for carbon-components-react ready! Built with commit 2c3feba https://deploy-preview-4696--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 2c3feba |
vpicone
reviewed
Nov 15, 2019
vpicone
suggested changes
Nov 15, 2019
|
Deploy preview for the-carbon-components ready! Built with commit 2c3feba https://deploy-preview-4696--the-carbon-components.netlify.com |
jnm2377
reviewed
Nov 15, 2019
removes unpopulated 'aliases' prop
I don't think we've populated that anywhere yet. future property |
`aliases:` a required prop?
vpicone
approved these changes
Nov 15, 2019
joshblack
approved these changes
Nov 18, 2019
joshblack
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
New
32/improve-relevance.svg
32/phrase-sentiment.svg
32/folders.svg
32/exit.svg
32/document-sentiment.svg
32/character-patterns.svg
Changed
Testing / Reviewing
{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}