Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(header-panel): add refs #4738

Merged
merged 3 commits into from
Nov 23, 2019
Merged

Conversation

paul-sachs
Copy link

Closes #4737

Add missing refs

Changelog

New

  • New ref for HeaderGlobalAction and HeaderPabel

@paul-sachs paul-sachs requested a review from a team as a code owner November 20, 2019 20:14
@ghost ghost requested review from asudoh and joshblack November 20, 2019 20:14
@netlify
Copy link

netlify bot commented Nov 20, 2019

Deploy preview for the-carbon-components ready!

Built with commit 141183b

https://deploy-preview-4738--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Nov 20, 2019

Deploy preview for carbon-elements ready!

Built with commit 141183b

https://deploy-preview-4738--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Nov 20, 2019

Deploy preview for carbon-components-react ready!

Built with commit 141183b

https://deploy-preview-4738--carbon-components-react.netlify.com

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM basically, could you add displayName support? Thanks @psachs21!

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like some snapshots need updating to pass CI tests

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @psachs21 for the update!

@asudoh asudoh merged commit 20598c8 into carbon-design-system:master Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forward refs for a few more components: HeaderGlobalAction, HeaderPanel
4 participants