Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pagination): input wrapper alignment closes #4733 #4740

Merged

Conversation

vpicone
Copy link
Contributor

@vpicone vpicone commented Nov 20, 2019

Regression was likely due to IE fixes, test in all browsers

@vpicone vpicone requested a review from a team as a code owner November 20, 2019 21:23
@ghost ghost requested review from abbeyhrt and joshblack November 20, 2019 21:23
@netlify
Copy link

netlify bot commented Nov 20, 2019

Deploy preview for carbon-elements ready!

Built with commit 9a78369

https://deploy-preview-4740--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Nov 20, 2019

Deploy preview for carbon-components-react ready!

Built with commit 9a78369

https://deploy-preview-4740--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Nov 20, 2019

Deploy preview for the-carbon-components ready!

Built with commit 9a78369

https://deploy-preview-4740--the-carbon-components.netlify.com

Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh my VM for IE11 is expired so will need to refresh. Tested though in latest:

  • Chrome
  • Safari
  • Firefox
  • Edge for Mac

@vpicone
Copy link
Contributor Author

vpicone commented Nov 20, 2019

@joshblack here's ie11:

ie11

@joshblack
Copy link
Contributor

@vpicone lol love the browser version info in the screenshot

@abbeyhrt abbeyhrt requested a review from a team November 20, 2019 22:20
@ghost ghost requested review from jeanservaas and removed request for a team November 20, 2019 22:20
@abbeyhrt abbeyhrt removed the request for review from jeanservaas November 20, 2019 22:21
Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also don't have access to IE11 but checked in the same browsers and the IE11 screenshot and it looks good to me! Would we need design approval on something like this?

@joshblack
Copy link
Contributor

Just verified with IE11 👍

@joshblack joshblack merged commit ef71b54 into carbon-design-system:master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants