docs(react): update links in carbon-components-react readme #4746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
jendowns
commented
Nov 21, 2019
|
Deploy preview for carbon-elements ready! Built with commit d51a11a |
|
Deploy preview for the-carbon-components ready! Built with commit d51a11a https://deploy-preview-4746--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit d51a11a https://deploy-preview-4746--carbon-components-react.netlify.com |
aledavila
approved these changes
Nov 21, 2019
|
Thank you @aledavila! I just updated that link in my latest commit 👍 |
joshblack
approved these changes
Nov 21, 2019
|
@jendowns could you run prettier real quick on the file? Should be |
jendowns
commented
Nov 22, 2019
There was a problem hiding this comment.
@joshblack @emyarod I just ran yarn format & pushed the update 👍
I also have a note about at pre-commit linting error below.
joshblack
reviewed
Nov 22, 2019
Co-Authored-By: Josh Black <josh@josh.black>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating 2 links -- one was outdated, one (for the developer docs) was 404ing
Changelog
Changed
carbon-components-reactREADME