Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react): update storybook to use fast-sass-loader in dev #4747

Merged

Conversation

joshblack
Copy link
Contributor

Update our sass config to use fast-sass-loader in development, while still using sass-loader in production builds. Also enables external CSS by default in prod.

Changelog

New

Changed

  • Add copyright banners
  • Update entrypoint to hooks
  • Update sass strategy to use conditionally use fast-sass-loader

Removed

Testing / Reviewing

  • Pull down PR
  • Run yarn storybook in packages/react
  • Change a style in a component file, like _button.scss and verify compilation takes <5s
  • Run yarn build-storybook to build storybook files
  • Run npx serve storybook-static and visit and verify project built correctly

@joshblack joshblack requested a review from a team as a code owner November 21, 2019 22:26
@ghost ghost requested a review from asudoh November 21, 2019 22:26
@joshblack
Copy link
Contributor Author

@emyarod this should address your comments from earlier!

@netlify
Copy link

netlify bot commented Nov 21, 2019

Deploy preview for the-carbon-components ready!

Built with commit 09af2b9

https://deploy-preview-4747--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Nov 21, 2019

Deploy preview for carbon-elements ready!

Built with commit 09af2b9

https://deploy-preview-4747--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Nov 21, 2019

Deploy preview for carbon-components-react failed.

Built with commit 09af2b9

https://app.netlify.com/sites/carbon-components-react/deploys/5dd70f24473c9f000847b987

@netlify
Copy link

netlify bot commented Nov 21, 2019

Deploy preview for the-carbon-components ready!

Built with commit 0cebf1a

https://deploy-preview-4747--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Nov 21, 2019

Deploy preview for carbon-elements ready!

Built with commit 0cebf1a

https://deploy-preview-4747--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Nov 21, 2019

Deploy preview for carbon-components-react ready!

Built with commit 0cebf1a

https://deploy-preview-4747--carbon-components-react.netlify.com

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running yarn install will also create the offline mirror for the async package which doesn't seem to be checked in? otherwise looks good to me

@joshblack
Copy link
Contributor Author

Thanks @emyarod! Updated

Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joshblack joshblack merged commit 45a8697 into carbon-design-system:master Nov 22, 2019
@joshblack joshblack deleted the 4527-update-storybook-setup branch November 22, 2019 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants