-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(react): update storybook to use fast-sass-loader in dev #4747
chore(react): update storybook to use fast-sass-loader in dev #4747
Conversation
@emyarod this should address your comments from earlier! |
Deploy preview for the-carbon-components ready! Built with commit 09af2b9 https://deploy-preview-4747--the-carbon-components.netlify.com |
Deploy preview for carbon-elements ready! Built with commit 09af2b9 |
Deploy preview for carbon-components-react failed. Built with commit 09af2b9 https://app.netlify.com/sites/carbon-components-react/deploys/5dd70f24473c9f000847b987 |
Deploy preview for the-carbon-components ready! Built with commit 0cebf1a https://deploy-preview-4747--the-carbon-components.netlify.com |
Deploy preview for carbon-elements ready! Built with commit 0cebf1a |
Deploy preview for carbon-components-react ready! Built with commit 0cebf1a https://deploy-preview-4747--carbon-components-react.netlify.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
running yarn install
will also create the offline mirror for the async
package which doesn't seem to be checked in? otherwise looks good to me
…rbon into 4527-update-storybook-setup
…4527-update-storybook-setup
Thanks @emyarod! Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Update our sass config to use
fast-sass-loader
in development, while still usingsass-loader
in production builds. Also enables external CSS by default in prod.Changelog
New
Changed
fast-sass-loader
Removed
Testing / Reviewing
yarn storybook
inpackages/react
_button.scss
and verify compilation takes <5syarn build-storybook
to build storybook filesnpx serve storybook-static
and visit and verify project built correctly