-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(select): remove label on svg chevron #4756
fix(select): remove label on svg chevron #4756
Conversation
Deploy preview for carbon-elements ready! Built with commit aa383e2 |
Deploy preview for the-carbon-components ready! Built with commit aa383e2 https://deploy-preview-4756--the-carbon-components.netlify.com |
Deploy preview for carbon-components-react ready! Built with commit aa383e2 https://deploy-preview-4756--carbon-components-react.netlify.com |
@aledavila @abbeyhrt @dakahn let me know if you want to go over the PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Sounds good. Checked with JAWS and NVDA on Win10 with Edge and Chrome latest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 - Thanks @joshblack!
Closes #3451
Closes #3449
Closes #4222
Changelog
New
Changed
aria-label
androle="img"
from iconiconDescription
propiconDescription
Removed
Testing / Reviewing
role="img"
):