fix(code-snippet): re-introduce bx--snippet-button class to copy button #4773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-components-react ready! Built with commit c5a0092 https://deploy-preview-4773--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit c5a0092 |
|
Deploy preview for the-carbon-components ready! Built with commit c5a0092 https://deploy-preview-4773--the-carbon-components.netlify.com |
joshblack
approved these changes
Nov 26, 2019
|
Thanks! @joshblack @emyarod so will #4741 be merged in time for the next release, to avoid releasing the copy button style regression? |
|
not certain about the timing of #4741 given that it's not entirely in my hands (awaiting reviews), but just wanted to give heads up about the possible future of this component |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4772
Recent changes have left out the
bx--snippet-buttonclass that was previously added to the copy button inside theCodeSnippetcomponent.This class adds necessary positioning styles etc.
The regression that this PR resolves is only visible if you run the latest
masterbranch locally, or if you view a recent PR deployment like this one: https://deploy-preview-4760--carbon-components-react.netlify.com/?path=/story/codesnippet--multi-lineChangelog
New
bx--snippet-buttonclass for copy button style & positioningTesting / Reviewing
Compare this PR's React storybook deployment (where the copy button position is fixed) to the another PR's storybook deployment like this one: https://deploy-preview-4760--carbon-components-react.netlify.com/?path=/story/codesnippet--multi-line