fix(pagination): prevent text from disappearing at certain sizes #4776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for the-carbon-components ready! Built with commit 485d67f https://deploy-preview-4776--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 485d67f |
|
Deploy preview for carbon-components-react ready! Built with commit 485d67f https://deploy-preview-4776--carbon-components-react.netlify.com |
Carbon React accessibility
automation
moved this from Pull requests 🙏🏿
to Closed issues 🏁
Nov 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4248
ref #1518
Pagination text was being hidden in a media query style block which is also triggered by zooming in on the page. This behavior does not seem to match the component spec
Changelog
Changed
Removed
display: noneon pagination component textTesting / Reviewing
Ensure the component matches the spec and the original zoom/reflow issue is no longer present