fix(Modal): remove z-index transition #4777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for the-carbon-components ready! Built with commit 2a9f931 https://deploy-preview-4777--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 2a9f931 |
|
Deploy preview for carbon-components-react ready! Built with commit 2a9f931 https://deploy-preview-4777--carbon-components-react.netlify.com |
|
@emyarod If you remove the transition from the Therefore my question is, can we have the |
|
@emyarod I pushed my proposal of the transitions with a permanent z-index: z('modal'); // 9000I also noticed that the |
aagonzales
approved these changes
Nov 26, 2019
emyarod
approved these changes
Nov 27, 2019
asudoh
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4690
Removes z-index transition on Modal component preventing visual and performance issues (see #4690 for more information).
Is there a reason why the
z-indexof the Modal needs to be-1when hidden? I needed to re-add the transition on one state to prevent the same visual bug to appear when closing the modal. As @sabov noted though, it'd be better ifz-indexwouldn't be transitioned at all.