Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pictograms): correct berlin brandenburg name typo #4778

Merged
merged 2 commits into from
Dec 5, 2019

Conversation

janhassel
Copy link
Member

As noted in #4610, the gate in Berlin is called "Brandenburg Gate", not "Brandenberg Gate". This PR just fixes this typo.

@janhassel janhassel requested a review from a team as a code owner November 26, 2019 13:56
@ghost ghost requested review from aledavila and joshblack November 26, 2019 13:56
@netlify
Copy link

netlify bot commented Nov 26, 2019

Deploy preview for the-carbon-components ready!

Built with commit e6e5cc3

https://deploy-preview-4778--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Nov 26, 2019

Deploy preview for carbon-elements ready!

Built with commit e6e5cc3

https://deploy-preview-4778--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Nov 26, 2019

Deploy preview for carbon-components-react ready!

Built with commit e6e5cc3

https://deploy-preview-4778--carbon-components-react.netlify.com

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on a side note, are the SVG ID's auto generated? if so we should make sure to update the source files as well

@janhassel
Copy link
Member Author

Good point, @emyarod. Do you know who maintains the source files?

Copy link
Contributor

@aledavila aledavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@emyarod
Copy link
Member

emyarod commented Dec 4, 2019

@janhassel, I'm not sure but most likely the design group will know cc @carbon-design-system/design

@joshblack
Copy link
Contributor

joshblack commented Dec 5, 2019

I think they come from the icon AI file 👍 will bump @conradennis just so he's aware

@joshblack joshblack merged commit 98dd0dc into carbon-design-system:master Dec 5, 2019
@janhassel janhassel deleted the berlin-brandenburg branch April 23, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants