fix(select): add flex rule to accommodate long label text, update story #4787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
jendowns
changed the title
jendowns
changed the title
|
Deploy preview for the-carbon-components ready! Built with commit d130c4a https://deploy-preview-4787--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit d130c4a |
|
Deploy preview for carbon-components-react ready! Built with commit d130c4a https://deploy-preview-4787--carbon-components-react.netlify.com |
joshblack
approved these changes
Dec 2, 2019
designertyler
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4757
In the deployed storybook environment, you can see that if the
Selectcomponent'slabelTextis longer than the width of the inner<select>element, the caret icon's positioning is off:This PR adds a flex alignment rule to fix that issue & also adds
labelTextas a prop to theSelectcomponent story so that the label can be experimented with more easily:Changelog
New
align-items: flex-starttoSelectcomponent wrapperlabelTextprop to knobs inSelectstory