fix(DatePicker): support focus into a day with min/max #4793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows user to focus a date into down-arrow key when min/max dates are enabled. When min/max dates are enabled, there can be no selected date in the calendar dropdown or calendar dropdown may not show today, so we need to look for another date to focus on. This change uses the first focusable date. Fixes carbon-design-system#4207.
ghost
requested review from
aagonzales
and removed request for
aagonzales and
a team
|
Deploy preview for the-carbon-components ready! Built with commit 079b0eb https://deploy-preview-4793--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react failed. Built with commit 079b0eb https://app.netlify.com/sites/carbon-components-react/deploys/5deeb1361d4c41000af6f6f8 |
|
Deploy preview for carbon-elements ready! Built with commit 079b0eb |
joshblack
approved these changes
Dec 2, 2019
dakahn
approved these changes
Dec 6, 2019
laurenmrice
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows user to focus a date into down-arrow key when min/max dates are enabled. When min/max dates are enabled, there can be no selected date in the calendar dropdown or calendar dropdown may not show today, so we need to look for another date to focus on. This change uses the first focusable date.
Fixes #4207.
Changelog
New
Testing / Reviewing
Testing should make sure React date picker is not broken.