Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(type): add font-family import #4795

Merged
merged 1 commit into from
Nov 29, 2019

Conversation

SimonFinney
Copy link
Contributor

Changelog

Changed

  • Add font-family import to @carbon/type/scss/styles to prevent carbon--font-weight not being found in isolation.

@SimonFinney SimonFinney requested a review from a team as a code owner November 28, 2019 11:26
@ghost ghost requested review from aledavila and joshblack November 28, 2019 11:26
@netlify
Copy link

netlify bot commented Nov 28, 2019

Deploy preview for the-carbon-components ready!

Built with commit c249712

https://deploy-preview-4795--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Nov 28, 2019

Deploy preview for carbon-elements ready!

Built with commit c249712

https://deploy-preview-4795--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Nov 28, 2019

Deploy preview for carbon-components-react failed.

Built with commit c249712

https://app.netlify.com/sites/carbon-components-react/deploys/5ddfaed129029b0007f1818b

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @SimonFinney!

@asudoh asudoh merged commit 1843d74 into carbon-design-system:master Nov 29, 2019
@SimonFinney SimonFinney deleted the patch-1 branch December 1, 2019 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants