fix(search): fix a11y structure #4801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change does the following things: * Ensures that the `<label>` in `<Search>` is hidden when `<TableToolbarSearch>` hides it. This fixes the orphaned relationship between `<input>` and `<label>` when search box is collpased and fixes "INPUT LABEL references must be valid" DAP error * Changes the ARIA role of the search container in `<TableToolbarSearch>` to `search` rather than `searchbox`, to better reflect its "container" nature. Also added `searchbox` role to the underlying `<input>` to reflect where the search box is. This lets VoiceOver announce the `<input>` inside `<Search>` as a "search text field" rather than "edit text", and fixes "An interactive element/widget must have an accessible name" DAP error when search box is expanded Fixes carbon-design-system#3806.
|
Deploy preview for carbon-elements ready! Built with commit 53603e2 |
|
Deploy preview for the-carbon-components ready! Built with commit 53603e2 https://deploy-preview-4801--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit 53603e2 https://deploy-preview-4801--carbon-components-react.netlify.com |
joshblack
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change does the following things:
<label>in<Search>is hidden when<TableToolbarSearch>hides it. This fixes the orphaned relationship between<input>and<label>when search box is collpased and fixes "INPUT LABEL references must be valid" DAP error<TableToolbarSearch>tosearchrather thansearchbox, to better reflect its "container" nature. Also addedsearchboxrole to the underlying<input>to reflect where the search box is. This lets VoiceOver announce the<input>inside<Search>as a "search text field" rather than "edit text", and fixes "An interactive element/widget must have an accessible name" DAP error when search box is expandedFixes #3806.
Changelog
Changed
<label>in<Search>is hidden when<TableToolbarSearch>hides it<TableToolbarSearch>tosearchrather thansearchboxTesting / Reviewing
Testing should make sure
<Search>and<TableToolbarSearch>are not broken.