Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bundler): Javascript bundler not consistently creating directories on windows #4811

Merged
merged 1 commit into from
Dec 4, 2019
Merged

fix(bundler): Javascript bundler not consistently creating directories on windows #4811

merged 1 commit into from
Dec 4, 2019

Conversation

sichangi
Copy link
Contributor

@sichangi sichangi commented Dec 3, 2019

Closes #2434

Initially the javascript bundler only created es directories, this PR allows it to create appropriate directories.

Changelog

Changed

  • The approach bundles all output formats into respective es, umd & lib directories

Testing / Reviewing

Packages using the bundle command have three output directories, es, umd & lib.

@sichangi sichangi requested a review from a team as a code owner December 3, 2019 20:43
@ghost ghost requested review from asudoh and dakahn December 3, 2019 20:43
@netlify
Copy link

netlify bot commented Dec 3, 2019

Deploy preview for the-carbon-components ready!

Built with commit 5e8e6d1

https://deploy-preview-4811--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Dec 3, 2019

Deploy preview for carbon-elements ready!

Built with commit 5e8e6d1

https://deploy-preview-4811--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Dec 3, 2019

Deploy preview for carbon-components-react ready!

Built with commit 5e8e6d1

https://deploy-preview-4811--carbon-components-react.netlify.com

@asudoh asudoh requested a review from joshblack December 3, 2019 21:33
asudoh
asudoh reviewed Dec 3, 2019
View reviewed changes
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM basically, could you please show what the output with UN*X systems will be with the new code? I'm asking this because I have an impression that we have special handling for ESM with old code, and wanted to make sure anything behind that logic won't be broken. Thanks!

@joshblack joshblack mentioned this pull request Dec 3, 2019
Closed
@sichangi
Copy link
Contributor Author

sichangi commented Dec 4, 2019 •
edited

@asudoh So, I setup an Ubuntu vm to test this out, and it works as expected
Here is a shot of the logs:

image

asudoh
asudoh approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sichangi for taking a look! Some more analysis in addition to what @sichangi did shows that the change yields the equivalent result as before-change.

@asudoh asudoh merged commit d93a23e into carbon-design-system:master Dec 4, 2019
@sichangi sichangi deleted the fix-bundler-not-creating-directories branch December 4, 2019 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asudoh asudoh asudoh approved these changes

@joshblack joshblack joshblack approved these changes

@dakahn dakahn Awaiting requested review from dakahn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Carbon bundler not properly creating directories on Windows
4 participants
@sichangi @asudoh @joshblack @mecolela