Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modal): fix header padding for small variants #4813

Merged
merged 5 commits into from
Dec 6, 2019
Merged

fix(modal): fix header padding for small variants #4813

merged 5 commits into from
Dec 6, 2019

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Dec 3, 2019

Fixes #4759.

Changelog

Changed

  • The right padding of modal header for smaller variants.

Testing / Reviewing

Testing should make sure our modal is not broken.

@asudoh asudoh requested review from emyarod, abbeyhrt and a team December 3, 2019 23:10
@asudoh asudoh requested a review from a team as a code owner December 3, 2019 23:10
@ghost ghost requested review from designertyler and removed request for a team December 3, 2019 23:10
@netlify
Copy link

netlify bot commented Dec 3, 2019 •
edited

Deploy preview for the-carbon-components ready!

Built with commit f7d524c

https://deploy-preview-4813--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Dec 3, 2019 •
edited

Deploy preview for carbon-components-react ready!

Built with commit f7d524c

https://deploy-preview-4813--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Dec 3, 2019 •
edited

Deploy preview for carbon-elements ready!

Built with commit f7d524c

https://deploy-preview-4813--carbon-elements.netlify.com

emyarod
emyarod reviewed Dec 4, 2019
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do these values need to be tokens instead?

@asudoh
Copy link
Contributor Author

asudoh commented Dec 4, 2019

@emyarod Makes sense - Updated.

joshblack
joshblack suggested changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance we could use spacing tokens from the spacing scale?

abbeyhrt
abbeyhrt approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@abbeyhrt abbeyhrt left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with the changes Josh suggested!

@asudoh
Copy link
Contributor Author

asudoh commented Dec 4, 2019

@joshblack @abbeyhrt Do you guys mean $layout-md or something else...?

@joshblack
Copy link
Contributor

If I understand correctly, the t-shirt sizes for spacing have been replaced by the spacing and layout scales. I believe spacing-3xl is 48px which maps over to $spacing-09 or $carbon--spacing-09 👍

@asudoh
Copy link
Contributor Author

asudoh commented Dec 5, 2019

Updated to $carbon--spacing-09

@asudoh asudoh merged commit bd6e4ea into carbon-design-system:master Dec 6, 2019
@asudoh asudoh deleted the small-modal-header-padding branch December 6, 2019 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod left review comments

@joshblack joshblack joshblack approved these changes

@abbeyhrt abbeyhrt abbeyhrt approved these changes

@designertyler designertyler designertyler approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Modal- Title only example]: close button overlaps text
6 participants
@asudoh @joshblack @emyarod @abbeyhrt @designertyler @laurenmrice