fix(number-input): removes role from icon and adds conditional aria label #4816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for the-carbon-components ready! Built with commit 623c4f8 https://deploy-preview-4816--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit 623c4f8 https://deploy-preview-4816--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 623c4f8 |
joshblack
approved these changes
Dec 4, 2019
dakahn
approved these changes
Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4532
This PR removes the unnecessary
role="img"fromWarningFilled16. To avoid both a label and an aria label on theinput, it changes thearia-labelon the input to only be applied when there is nolabelprovided.Changelog
New
aria-labelon input based on labelChanged
Removed
role="img"onWarningFilled16Testing / Reviewing
Check to make sure that NumberInput has no DAP violations