Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(radio-tile): remove invalid labelText prop from story #4829

Merged
merged 2 commits into from
Dec 6, 2019
Merged

docs(radio-tile): remove invalid labelText prop from story #4829

merged 2 commits into from
Dec 6, 2019

Conversation

jendowns
Copy link
Contributor

@jendowns jendowns commented Dec 6, 2019

labelText is not a valid prop for the RadioTile component, so when it is used in the React storybook it generates the following console error (in local development) --

Screen Shot 2019-12-06 at 1 28 59 PM

Text of error:

Warning: React does not recognize the `labelText` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `labeltext` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
    in input (created by RadioTile)
    in RadioTile (created by TileGroup)
    in div (created by TileGroup)
    in fieldset (created by TileGroup)
    in TileGroup (created by Container)
    in div (created by Story)
    in Story (created by Container)
    in div (created by Container)
    in StrictMode (created by Container)
    in Container (created by storyFn)
    in storyFn
    in ErrorBoundary

This PR proposes removing usage of labelText prop in the storybook, which removes the console errors in local development. 馃憤

Changelog

Removed

  • remove labelText prop usage in RadioTile component story

Testing / Reviewing

I suggest running the storybook locally & then viewing the dev console in Chrome
Even without pulling down my remote, you could run the storybook, observe the console errors, and then remove the lines that I removed -- the usage of labelText

@jendowns jendowns requested a review from a team as a code owner December 6, 2019 19:34
@ghost ghost requested review from aledavila and dakahn December 6, 2019 19:34
@netlify
Copy link

netlify bot commented Dec 6, 2019

Deploy preview for the-carbon-components ready!

Built with commit cc197bc

https://deploy-preview-4829--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Dec 6, 2019

Deploy preview for carbon-elements ready!

Built with commit cc197bc

https://deploy-preview-4829--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Dec 6, 2019

Deploy preview for carbon-components-react ready!

Built with commit cc197bc

https://deploy-preview-4829--carbon-components-react.netlify.com

Copy link
Contributor

@dakahn dakahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃弰 Thanks!

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤 - Thanks @jendowns!

@asudoh asudoh merged commit ed337fe into carbon-design-system:master Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants