docs: remove deprecated small button prop usage from React stories
#4831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 7c75414 |
|
Deploy preview for the-carbon-components ready! Built with commit 7c75414 https://deploy-preview-4831--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit 7c75414 https://deploy-preview-4831--carbon-components-react.netlify.com |
dakahn
approved these changes
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two instances where the deprecated
Buttonpropsmallis still used in storybook -- in theButtonstories and in aFileUploaderstory.The presence of this deprecated prop generates console errors in local development, so I wanted to suggest removing their usage in storybook. I understand the next to keep them in existing tests, but in this case I think it would be beneficial to remove them from demos.
Please let me know what you think -- thank you! 馃憤
Changelog
Removed
Buttonpropsmallusage from storiesTesting / Reviewing
Best way to view the console errors, in my experience, is to run the storybook environment locally & view the dev console in Chrome.