Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(icons): update source & repo links on carbon elements demo page #4852

Merged
merged 2 commits into from
Dec 11, 2019
Merged

Conversation

jendowns
Copy link
Contributor

@jendowns jendowns commented Dec 10, 2019

There are a number of links on the Carbon Elements / @carbon/icons preview page (https://carbon-elements.netlify.com/icons/examples/preview/) that go to the old repo location, including all of the icon source code links and then the "open an issue" links. Currently if you try to go to any of those links in the icons table, they will 404.

The PR updates those paths to the new monorepo locations 馃憤

Changelog

Changed

  • update links to new monorepo paths

@jendowns jendowns requested a review from a team as a code owner December 10, 2019 20:04
@ghost ghost requested review from asudoh and joshblack December 10, 2019 20:04
@netlify
Copy link

netlify bot commented Dec 10, 2019

Deploy preview for carbon-components-react failed.

Built with commit a14e8ad

https://app.netlify.com/sites/carbon-components-react/deploys/5df02f5149f69500094e8bb7

@netlify
Copy link

netlify bot commented Dec 10, 2019

Deploy preview for carbon-elements ready!

Built with commit a14e8ad

https://deploy-preview-4852--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Dec 10, 2019

Deploy preview for the-carbon-components ready!

Built with commit a14e8ad

https://deploy-preview-4852--the-carbon-components.netlify.com

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤 - Thanks @jendowns!

@asudoh asudoh merged commit 2897bc9 into carbon-design-system:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants