fix(linear-gradient): use transparent color instead of keyword for Safari fix #4859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
jendowns
changed the title
jendowns
changed the title
joshblack
approved these changes
Dec 11, 2019
|
Deploy preview for the-carbon-components ready! Built with commit 283cfe0 https://deploy-preview-4859--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 283cfe0 |
|
Deploy preview for carbon-components-react ready! Built with commit 283cfe0 https://deploy-preview-4859--carbon-components-react.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit 9882ca5 https://deploy-preview-4859--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 9882ca5 |
|
Deploy preview for the-carbon-components ready! Built with commit 9882ca5 https://deploy-preview-4859--the-carbon-components.netlify.com |
abbeyhrt
approved these changes
Dec 11, 2019
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modalin this PR, where the same situation applies to the content overflow linear-gradientSafari interprets the
transparentkeyword (which maps torgba(0, 0, 0, 0)) differently, which causes the visual issue outlined in #4769. In short: this visual issue causes linear gradients used in theCodeSnippet&Modalcomponents to appear darker, like a transparent black, when viewed in Safari.Here a couple links explaining this:
Changelog
Changed
rgba()color function to make primary gradient color transparent, rather than usingtransparentkeyword, in both theCodeSnippetandModalcomponents