Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(project): add DOM test helpers #4860

Merged

Conversation

joshblack
Copy link
Contributor

Adding in some test helpers that @dakahn was looking for with loading work 馃憖

Changelog

New

  • Add test-utils/dom.js with the following helpers
    • getByText
    • isElementVisible
    • debug

Changed

  • Update an AccordionItem test to use new helpers as an example

Removed

@joshblack joshblack requested a review from a team as a code owner December 11, 2019 16:49
@netlify
Copy link

netlify bot commented Dec 11, 2019

Deploy preview for the-carbon-components ready!

Built with commit 4169e42

https://deploy-preview-4860--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Dec 11, 2019

Deploy preview for carbon-components-react ready!

Built with commit 4169e42

https://deploy-preview-4860--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Dec 11, 2019

Deploy preview for carbon-elements ready!

Built with commit 4169e42

https://deploy-preview-4860--carbon-elements.netlify.com

Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@dakahn dakahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you! 馃樃

@joshblack joshblack merged commit 4a4622c into carbon-design-system:master Dec 11, 2019
@joshblack joshblack deleted the test/add-dom-helpers branch December 11, 2019 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants