Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(data-table): update storybook to use correct button variant #4905

Conversation

joshblack
Copy link
Contributor

Our with batch actions story for Data Table used the now deprecated small prop. This PR updates it to use size="small" instead.

Changelog

New

Changed

  • Update button to use size="small" in batch actions story

Removed

Testing / Reviewing

  • Verify no deprecation notice is displayed in the with batch actions story

@joshblack joshblack requested a review from a team as a code owner December 17, 2019 19:20
@ghost ghost requested review from asudoh and emyarod December 17, 2019 19:20
@netlify
Copy link

netlify bot commented Dec 17, 2019

Deploy preview for the-carbon-components ready!

Built with commit bfb07e6

https://deploy-preview-4905--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Dec 17, 2019

Deploy preview for carbon-elements ready!

Built with commit bfb07e6

https://deploy-preview-4905--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Dec 17, 2019

Deploy preview for carbon-components-react ready!

Built with commit bfb07e6

https://deploy-preview-4905--carbon-components-react.netlify.com

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @joshblack!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants