fix(structuredlist): fixes DAP errrors #5066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakahn
requested review from
a team,
asudoh and
joshblack
and removed request for
a team
joshblack
approved these changes
Jan 16, 2020
|
Deploy preview for the-carbon-components ready! Built with commit 2fc1fbc https://deploy-preview-5066--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 2fc1fbc |
|
Deploy preview for carbon-components-react ready! Built with commit 2fc1fbc https://deploy-preview-5066--carbon-components-react.netlify.com |
abbeyhrt
approved these changes
Jan 16, 2020
ghost
requested a review
from 
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Jan 23, 2020
* fix(Dropdown): rely on list-box height closes carbon-design-system#4916 * fix(structuredlist): remove role=presentation, remove htmlFor attribute Co-authored-by: TJ Egan <tw15egan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1882
There were two remaining DAP errors for the StructuredList component:
Changed
role=presentationfrom the label elementNot 100% sure why this was there in the first place 馃槙, but easy clear by removing it
htmlForattribute prop from Storysince we have an implicit (wrapping) label this is unneeded.
Ongoing concerns
As was mentioned in this comment this component needs some work getting the underlying markup in line with what we actually want here and more importantly reading properly in a screen reader. Since we can clear the DAP errors now i'll roll the larger component rework into another ticket #5065
Testing / Reviewing
Test and make sure the StructuredList behaves as expected (should be no changes).