Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(multiselect): fix invalid inline multiselect error icon #5075

Merged
merged 4 commits into from Jan 17, 2020
Merged

fix(multiselect): fix invalid inline multiselect error icon #5075

merged 4 commits into from Jan 17, 2020

Conversation

tw15egan
Copy link
Member

Closes #5073

Removes some extra positioning styles that were causing the inline variation to be misaligned. This block should be able to handle position on its own.

.#{$prefix}--list-box__invalid-icon {
   top: 50%;
   transform: translateY(-50%);
}

Changelog

Removed

  • Extra position styles

Testing / Reviewing

  • Create an inline multi-select
  • Addtype="inline" on L113 in MultiSelect-story.js
  • In the storybook, enable error styles via the knob
  • Ensure icon is centered

@tw15egan tw15egan requested a review from a team as a code owner January 16, 2020 21:43
@asudoh asudoh requested review from a team and designertyler and removed request for a team January 16, 2020 21:43
asudoh
asudoh approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 👍 - Thanks @tw15egan!

@netlify
Copy link

netlify bot commented Jan 16, 2020 •
edited

Deploy preview for carbon-elements failed.

Built with commit 622a941

https://app.netlify.com/sites/carbon-elements/deploys/5e21e061e2043e00080dd108

@netlify
Copy link

netlify bot commented Jan 16, 2020

Deploy preview for carbon-components-react ready!

Built with commit b4de324

https://deploy-preview-5075--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Jan 16, 2020

Deploy preview for the-carbon-components ready!

Built with commit b4de324

https://deploy-preview-5075--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 16, 2020 •
edited

Deploy preview for the-carbon-components ready!

Built with commit 622a941

https://deploy-preview-5075--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 16, 2020 •
edited

Deploy preview for carbon-components-react failed.

Built with commit 622a941

https://app.netlify.com/sites/carbon-components-react/deploys/5e21e06182cbe4000a5cb679

designertyler
designertyler approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@designertyler designertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

jeanservaas
jeanservaas approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@jeanservaas jeanservaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeanservaas jeanservaas merged commit edfcb2f into carbon-design-system:master Jan 17, 2020
joshblack pushed a commit to joshblack/carbon that referenced this pull request Jan 23, 2020
@tw15egan @joshblack
fix(multiselect): fix invalid inline multiselect error icon (carbon-d…
67adf17 
…esign-system#5075)
@joshblack joshblack mentioned this pull request Jan 23, 2020
Closed
@joshblack joshblack mentioned this pull request Jan 31, 2020
Closed
@joshblack joshblack mentioned this pull request Feb 25, 2020
Closed
@tw15egan tw15egan deleted the multiselect-inline-error-fix branch April 28, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asudoh asudoh asudoh approved these changes

@designertyler designertyler designertyler approved these changes

@jeanservaas jeanservaas jeanservaas approved these changes

@joshblack joshblack Awaiting requested review from joshblack

Assignees
No one assigned
Labels
status: visual review 🔍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiselect inline icon error
4 participants
@tw15egan @asudoh @designertyler @jeanservaas