Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add check href exists when handle onBlur #5352

Merged

Conversation

xxxle0
Copy link
Contributor

@xxxle0 xxxle0 commented Feb 14, 2020

Closes #5351

  • Check href attribute

Changelog

New

  • {{new thing}}

Changed

  • {{change thing}}

Removed

  • {{removed thing}}

Testing / Reviewing

{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}

@xxxle0 xxxle0 requested a review from a team as a code owner February 14, 2020 01:01
@ghost ghost requested review from abbeyhrt and dakahn February 14, 2020 01:01
@netlify
Copy link

netlify bot commented Feb 14, 2020

Deploy preview for carbon-elements ready!

Built with commit 8cd8b21

https://deploy-preview-5352--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Feb 14, 2020

Deploy preview for carbon-components-react ready!

Built with commit 8cd8b21

https://deploy-preview-5352--carbon-components-react.netlify.com

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @xxxle0!

@joshblack
Copy link
Contributor

For whoever merges, I think we'll need to update the commit message to fix:

fix(ui-shell): add check for if href exists when handling onBlur

@tw15egan tw15egan merged commit 50b14ff into carbon-design-system:master Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UIShell]: HeaderMenu does not close if you click a HeaderGlobalAction
5 participants