Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Slider): onRelease not always firing (#2695) #5359

Commits on Feb 14, 2020

  1. Copy the full SHA
    a5498b4 View commit details
    Browse the repository at this point in the history
  2. test(windows): fixing failing unit tests

    * Updating jest `testMatch` micromatch expressions (jestjs/jest#7914)
    * Replacing `/` with `path.sep` in icon-build-helpers search.js
    * Replacing regex using `/` with `[\\/]` in test-utils scss.js
    jdharvey-ibm committed Feb 14, 2020
    Copy the full SHA
    f3e84ba View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2020

  1. Copy the full SHA
    cb04ebf View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2020

  1. refactor(Slider): reworking event logic

    - Adding lodash.throttle as project dependency for use in Slider
    - Reworking Slider component's event handling
    - Including throttling in Slider event handling
    - Adjusting CSS for input element on Slider
    jdharvey-ibm committed Feb 24, 2020
    Copy the full SHA
    2545e7a View commit details
    Browse the repository at this point in the history
  2. Merge branch '2695-fix-onrelease-sometimes-doesnt-fire' of https://gi…

    …thub.com/jdharvey-ibm/carbon into 2695-fix-onrelease-sometimes-doesnt-fire
    jdharvey-ibm committed Feb 24, 2020
    Copy the full SHA
    2f7054f View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2020

  1. test(Slider): updating/adding unit tests

    - Increasing (line) test coverage to 100%
    - Slight refactor of functions to be more testable
    - Correctly handling hidden text input
    - Correctly handling touchmove events
    - Gracefully handling edge case of zero-width bounding rect
    jdharvey-ibm committed Feb 25, 2020
    Copy the full SHA
    dd3f739 View commit details
    Browse the repository at this point in the history
  2. fix(Slider): code review updates

    - Removing usage of functions that aren't available in all browsers
    - Adding unit test for display:none style on hidden text input
    jdharvey-ibm committed Feb 25, 2020
    Copy the full SHA
    57827fd View commit details
    Browse the repository at this point in the history
  3. fix(Slider): code review updates

    - Removing throttling from keydown handling
    - Updating unit tests accordingly
    jdharvey-ibm committed Feb 25, 2020
    Copy the full SHA
    c38670e View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2020

  1. Copy the full SHA
    3600eb8 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2020

  1. Copy the full SHA
    39e34c3 View commit details
    Browse the repository at this point in the history
  2. refactor(Slider): use matches module

    Using `matches(...)` for arrow key event matching instead of custom impl
    jdharvey-ibm committed Feb 28, 2020
    Copy the full SHA
    dcae226 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'master' of github.com:carbon-design-system/carbon into …

    …2695-fix-onrelease-sometimes-doesnt-fire
    jdharvey-ibm committed Feb 28, 2020
    Copy the full SHA
    34bde1f View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2020

  1. Copy the full SHA
    6729a2b View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    7c6a641 View commit details
    Browse the repository at this point in the history