New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Slider): onRelease not always firing (#2695) #5359
fix(Slider): onRelease not always firing (#2695) #5359
Commits on Feb 14, 2020
-
test(windows): fixing failing unit tests
* Updating jest `testMatch` micromatch expressions (jestjs/jest#7914) * Replacing `/` with `path.sep` in icon-build-helpers search.js * Replacing regex using `/` with `[\\/]` in test-utils scss.js
Commits on Feb 17, 2020
Commits on Feb 24, 2020
-
refactor(Slider): reworking event logic
- Adding lodash.throttle as project dependency for use in Slider - Reworking Slider component's event handling - Including throttling in Slider event handling - Adjusting CSS for input element on Slider
-
Merge branch '2695-fix-onrelease-sometimes-doesnt-fire' of https://gi…
…thub.com/jdharvey-ibm/carbon into 2695-fix-onrelease-sometimes-doesnt-fire
Commits on Feb 25, 2020
-
test(Slider): updating/adding unit tests
- Increasing (line) test coverage to 100% - Slight refactor of functions to be more testable - Correctly handling hidden text input - Correctly handling touchmove events - Gracefully handling edge case of zero-width bounding rect
-
fix(Slider): code review updates
- Removing usage of functions that aren't available in all browsers - Adding unit test for display:none style on hidden text input
-
fix(Slider): code review updates
- Removing throttling from keydown handling - Updating unit tests accordingly
Commits on Feb 27, 2020
Commits on Feb 28, 2020
-
refactor(Slider): use matches module
Using `matches(...)` for arrow key event matching instead of custom impl
-
Merge branch 'master' of github.com:carbon-design-system/carbon into …
…2695-fix-onrelease-sometimes-doesnt-fire