feat(components): support alternate container tokens #6185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes text input, number input and text area components to reflect `$container-0x` tokens, so that those components work well with alternate set of type/container/icon tokens. This change also includes our (alternate) development environment setup, enabled with `CARBON_REACT_STORYBOOK_USE_EXPRESSIVE_THEME=true` environment variable, to test such alternate set of type/container/icon tokens. Refs carbon-design-system#6183.
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 6576b56 |
|
Deploy preview for carbon-components-react ready! Built with commit 6576b56 https://deploy-preview-6185--carbon-components-react.netlify.app |
This was referenced Jun 3, 2020
Closed
tw15egan
reviewed
Jun 4, 2020
| @@ -111,7 +111,7 @@ | |||
| justify-content: center; | |||
| align-items: center; | |||
| width: rem(32px); | |||
| height: rem(20px); | |||
| height: calc(#{$input-height} / 2); | |||
There was a problem hiding this comment.
Any reason we are using calc here, but on L232 we are doing an inline calc?
There was a problem hiding this comment.
Good catch @tw15egan! I meant to use calc() for other places, too, because Sass-based calculation does not work if e.g. $input-height has a CSS custom property as the value.
dakahn
approved these changes
Jun 5, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes text input, number input and text area components to reflect
$container-0xtokens, so that those components work well with alternate set of type/container/icon tokens.This change also includes our (alternate) development environment setup, enabled with
CARBON_REACT_STORYBOOK_USE_EXPRESSIVE_THEME=trueenvironment variable, to test such alternate set of type/container/icon tokens.Refs #6183.
Changelog
New
Testing / Reviewing
Testing should make sure text input, number input and text area as well as our development environment are not broken.