feat(modal): add preventCloseOnClickOutside prop to Modal #6886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moczolaszlo
changed the title
|
Sorry, I made typo in the commit message. |
|
Deploy preview for carbon-elements ready! Built with commit 0899785 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 0899785 https://deploy-preview-6886--carbon-components-react.netlify.app |
|
Deploy preview for carbon-elements ready! Built with commit 329be24 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 329be24 https://deploy-preview-6886--carbon-components-react.netlify.app |
tw15egan
approved these changes
Sep 22, 2020
dakahn
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #6793 .
Changelog
New
preventCloseOnClickOutsidetoModal.Changed
handleMousedown(Modal) to prevent closing when this prop is passed in and the click originates outside the modal itself.Testing / Reviewing
Enable the
preventCloseOnClickOutsideprop and try clicking outside of the modal. It should not close the modal. Ensure all variants ofModalrender properly and still close properly when the prop is not specified.(Yes, I copied a lot of text from the original PR 😄 .)